Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeout for file checking #3642

Merged
merged 12 commits into from
Jan 8, 2025
Merged

fix: timeout for file checking #3642

merged 12 commits into from
Jan 8, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 8, 2025

Description

It should help to alliviate stability issues.

Issue linked

Related to #3313

Checklist

@germa89 germa89 self-assigned this Jan 8, 2025
@germa89 germa89 requested a review from a team as a code owner January 8, 2025 11:47
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 force-pushed the fix/timeout-for-file-checking branch from b85cacb to 10a7268 Compare January 8, 2025 11:47
@germa89
Copy link
Collaborator Author

germa89 commented Jan 8, 2025

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jan 8, 2025
@germa89 germa89 changed the title Fix/timeout for file checking fix: timeout for file checking Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (e83f46c) to head (219bb1b).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3642      +/-   ##
==========================================
+ Coverage   87.08%   87.09%   +0.01%     
==========================================
  Files         187      187              
  Lines       14679    14694      +15     
==========================================
+ Hits        12783    12798      +15     
  Misses       1896     1896

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 8, 2025
@germa89 germa89 merged commit a7d4359 into main Jan 8, 2025
58 of 61 checks passed
@germa89 germa89 deleted the fix/timeout-for-file-checking branch January 8, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot